New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rehash trashes chars in story containing direct-entered chars > 0x0100 #41
Comments
Saw that. |
Okay, no, that was a varnish or memcached issue and it looks fine after clearing the cache. Reproduce it if you would. |
Right, this time I did NOTHING to any of the stories and they still turned into proper glyphs. Probably from some slashd job or other. |
Not fixed. |
This is an incredibly irritating bug. What I'm suspecting is happening is it depends on the charset the form replies are sending in. mod_perl should be setting the UTF-8 flag if that infact is the case. I use Ubuntu and Firefox and Chrome send their replies in UTF-8 encoding. I don't know what @TheMightyBuzzard uses but it appears to be the same on transmission encoding. @marty-b likely is using a different browser/OS combination that's sending it in a locale that isn't UTF-8, and rehash self-destructs when trying to encode/decode it. |
there is a form attribute that sets the char set. wonder if we need that set now. I think we were fudging it before. |
@paulej72 I'm concerned that if the site 500s if someone submits invalid requests. I need to rewrite the apparmor rules for A2 though ... |
This appears to have been fixed via a my.cnf fix on lithium. Closing. |
(1) Launched https://dev.soylentnews.org using Pale Moon Atom/WinXP (v25.3.2)
(2) Logged in
(3) Clicked Submit Story link on left-hand side of main page
(4) Copy/pasted text from file: UTF-8gen.000001-0007ff.txt
(5) Selected "Plain Old Text" as submission format
(6) Clicked PreviewStory
(7) Clicked SubmitStory
(8) Loaded Submissions List page: https://dev.soylentnews.org/submit.pl?op=list
(9) Clicked on submitted story - text in story looked okay
(10) Clicked Preview - text in story looked okay
(11) Clicked Submit
(12) Waited for story to appear on the main page
(13) Noticed that almost all chars >= 0x0100 were replaced with question marks "?"
(14) Story can be viewed at: https://dev.soylentnews.org/article.pl?sid=15/05/07/1946248
The text was updated successfully, but these errors were encountered: