Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not link to nonexisting dates #36

Closed
paulej72 opened this issue Mar 7, 2014 · 4 comments
Closed

should not link to nonexisting dates #36

paulej72 opened this issue Mar 7, 2014 · 4 comments

Comments

@paulej72
Copy link
Contributor

paulej72 commented Mar 7, 2014

currently the right-link at bottom to the page for earlier articles, links to dates that don't have any articles if you go some page back.

The page http://li694-22.members.linode.com/index.pl?issue=20140212
links to http://li694-22.members.linode.com/index.pl?issue=20140211
to 20140210 to 20140209 etc...
that don't have any articles (the first article is 12 February).

the link to earlier articles should not be there on 20140212, or not be a link.

< Today's News | February 13 | February 11 >

@paulej72
Copy link
Contributor Author

paulej72 commented Mar 7, 2014

Message
Date: 2014-03-01 22:27
Sender: Eric Paul

Need to purge the starter stories from the DB.

@NCommander NCommander added this to the Release 14.06 milestone Mar 30, 2014
@paulej72
Copy link
Contributor Author

this is an edge case problem. The code that does the older stories links does not check if there are any stories in a given date before putting up the link. This would require a database hit, and we may not want to fix as it will only affect new sites.

@paulej72 paulej72 modified the milestones: Release 14.08, Release 14.06 May 27, 2014
@TheMightyBuzzard
Copy link
Contributor

I vote we don't fix it. Like you said, it's an extra db hit for an extreme edge case. Now if we weren't throwing stories out every single day it might be worth the hit to show the last day that actually has stories rather than auto-linking yesterday's date. But we are.

@paulej72
Copy link
Contributor Author

This issue was moved to SoylentNews/rehash#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants