Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUI with separation of input and output #34

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

TUI with separation of input and output #34

wants to merge 7 commits into from

Conversation

JerelJr
Copy link

@JerelJr JerelJr commented May 10, 2024

Resolves #10

  • Adds an 'app' module for the TUI code.
  • Added modal interface to allow the user to switch scroll control between output box and input box using Esc key
  • Updated dependencies
  • Implemented clippy suggestions

@JerelJr JerelJr marked this pull request as ready for review May 10, 2024 23:23
the-Jamz
the-Jamz requested changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@the-Jamz the-Jamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, when I have a minute I'll check this across a few platforms to make sure everything is still working given the dependency updates. Thanks a lot for all the work you've done here!

src/app.rs
}
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could improve readability if we reduce the nesting here somehow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I combined some conditions from nested if statements and moved event handling into a separate function to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-Jamz the-Jamz the-Jamz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better terminal UI with seperation of input and output
2 participants
@JerelJr @the-Jamz