Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend catalog_eav_attribute Instead Of eav_attribute #5

Closed
sprankhub opened this issue Dec 6, 2019 · 2 comments
Closed

Extend catalog_eav_attribute Instead Of eav_attribute #5

sprankhub opened this issue Dec 6, 2019 · 2 comments

Comments

@sprankhub
Copy link
Collaborator

Since we only care about product attributes, wouldn't it be cleaner to store the tooltips in catalog_eav_attribute instead of eav_attribute? Would you mind merging a pull request?
@Spaggel
Copy link
Owner

Spaggel commented Dec 6, 2019

You're right, feel free to submit a pull request and I'll merge it asap 👍

@sprankhub sprankhub mentioned this issue Dec 9, 2019
Closed
@sprankhub
Copy link
Collaborator Author

We now use our own table, so this is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sprankhub @Spaggel