Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflow: hidden should be removed after initial render when isOpen={true} #9

Closed
mshwery opened this issue Apr 27, 2017 · 3 comments
Closed
Assignees

Comments

@mshwery
Copy link
Contributor

mshwery commented Apr 27, 2017

First off thanks for this component – came in handy in a pinch.

I have children components that have dropdowns that might spill over beyond the <Collapse /> parent component's height. The problem I'm encountering only happens when the initial render has isOpen={true}.

The inline style overflow: hidden is applied and remains on the component until you switch the state from isOpen={false}. In fact, once you toggle it yet again to isOpen={true} after being in the isOpen={false} state it does remove the overflow: hidden style with overflow: visible, which is what my child components require after the animation is complete.

@torleifhalseth torleifhalseth self-assigned this Apr 29, 2017
@torleifhalseth
Copy link
Contributor

torleifhalseth commented Apr 29, 2017

Hi Matt! I am glad the component works for you.
What version of the package are you using?
It would be very nice to provide an example for me to fully understand the issue. You can use the existing storybook project to provide a new story replicating your setup.

@mshwery
Copy link
Contributor Author

mshwery commented Apr 30, 2017

Here's an example of a dropdown component that gets cut off by the initial inline styles of Collapse: https://codesandbox.io/s/Dk1woW3xB

@torleifhalseth
Copy link
Contributor

Fixed by @mshwery here: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants