Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Dependency Injection instead of Mocking #13

Open
DavidAntaramian opened this issue Feb 27, 2016 · 1 comment
Open

Prefer Dependency Injection instead of Mocking #13

DavidAntaramian opened this issue Feb 27, 2016 · 1 comment

Comments

@DavidAntaramian
Copy link
Contributor

@richleland As I was going through the requirements for change implementation for #12 I realized that the tests depend significantly on mocking the behaviour of HTTPotion. Moving forward, would you be open to preferring a dependency injection model over mocking? This is the style preferred for Elixir core components (see "Mocks and explicit contracts" – José Valim on Plataformatec Blog).

My thoughts would be to do this once #12 is complete but prior to further development.

@richleland
Copy link
Contributor

Makes sense to me @DavidAntaramian we can tackle this right after #12 as you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants