Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

res.body is being returned as a string instead of being parsed to JSON #122

Closed
aydrian opened this issue Mar 22, 2016 · 2 comments
Closed

res.body is being returned as a string instead of being parsed to JSON #122

aydrian opened this issue Mar 22, 2016 · 2 comments
Assignees
@aydrian
Labels
🐛 bug
Milestone
2.0.0 Release

Comments

@aydrian
Copy link
Contributor

aydrian commented Mar 22, 2016

We are not setting the Content-type: application/json header on the base SparkPost request method. Need to add options.json = true; to the request options.
@aydrian aydrian self-assigned this Mar 22, 2016
@aydrian aydrian changed the title res.body is being returned as a string instead of being parsed to JSON res.body is being returned as a string instead of being parsed to JSON Mar 22, 2016
@aydrian aydrian added this to the 2.0.0 Release milestone Mar 22, 2016
@aydrian aydrian mentioned this issue Mar 22, 2016
Merged
@aydrian
Copy link
Contributor Author

aydrian commented Mar 22, 2016

This is only happening with GET requests. This would be a breaking change, so adding it to the 2.0.0 Release.

@aydrian
Copy link
Contributor Author

aydrian commented Mar 22, 2016

Closed by #123

@aydrian aydrian closed this as completed Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aydrian aydrian

Labels
🐛 bug
Projects
None yet
Milestone
2.0.0 Release
Development

No branches or pull requests
1 participant
@aydrian