Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle 6 #207

Open
AlexanderBech opened this issue Mar 10, 2022 · 9 comments
Open

Guzzle 6 #207

AlexanderBech opened this issue Mar 10, 2022 · 9 comments

Comments

@AlexanderBech
Copy link

Hi,

I got a composer package that requires guzzle 7.4. But can't upgrade to guzzle 7.4 because it says php-sparkpost needs guzzle 6.
What to do?

@ainsleyclark
Copy link

Any updates on this?

@ainsleyclark
Copy link

This seems to work:
composer require php-http/guzzle7-adapter
Then:
use Http\Adapter\Guzzle7\Client as GuzzleAdapter;

@phpfui
Copy link

phpfui commented Nov 7, 2022

@ainsleyclark Thanks for this. You just saved me hours! And just in time as well.

But the package should be updated.

@ainsleyclark
Copy link

Glad I could help, yeah would be good if this is updated to 7

@andrews05
Copy link

I'm a little confused about the issue here. The sparkpost package itself does not require guzzle at all, it's only the readme that tells you to install guzzle 6. Are you saying the readme should be updated?

@ainsleyclark
Copy link

ainsleyclark commented Feb 16, 2023

The sparkpost composer.json references Guzzle 6. It would be good to get it updated to 7 to fix above. It's cross referenced; you can't use this package with another package that uses Guzzle 7.

@andrews05
Copy link

andrews05 commented Feb 16, 2023

The reference is in dev dependencies though, which is only relevant to the package developers, not the package users (us). I just tried a fresh install, it works fine with guzzle 7. (The readme says to install guzzle 6, but there's no reason why you can't install guzzle 7 instead)

@ainsleyclark
Copy link

It's probably an edge case but I guess we've still encountered it during development.

@andrews05
Copy link

Yeah, I admit I've had difficulty upgrading from guzzle 6 to 7 when v6 is currently installed. But this isn't really a fault of the sparkpost package - changing the dev dependency to v7 wouldn't resolve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants