You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?
Yes, it's still reproducable
What version of Laravel Excel are you using?
3.1.40
What version of Laravel are you using?
9.11.0
What version of PHP are you using?
8.1.7
Describe your issue
The method signature for Excel::store does not match when faked, so using a named parameter for diskName tests fail with Unknown named parameter $diskName
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.
Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?
What version of Laravel Excel are you using?
3.1.40
What version of Laravel are you using?
9.11.0
What version of PHP are you using?
8.1.7
Describe your issue
The method signature for
Excel::store
does not match when faked, so using a named parameter fordiskName
tests fail withUnknown named parameter $diskName
But the method signature for the faked
Excel::store
, substituted whenExcel::fake()
is called is:$diskName <> $disk
How can the issue be reproduced?
Write some code that uses
Excel::Store()
and provide it a list of named parameters:In a test, call
Excel::fake()
and run the above codeWhat should be the expected behaviour?
The test should not throw a
Unknown named parameter $diskName parameter
error whenExcel
is faked.The text was updated successfully, but these errors were encountered: