[Bug]: isEmptyWhen never gets called in ModelImporter

[quantumwebco]

Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?

• Yes, it's still reproducable

What version of Laravel Excel are you using?

3.1.44

What version of Laravel are you using?

9.38

What version of PHP are you using?

8.1

Describe your issue

Using SkipsEmptyRows suggests that the method isEmptyWhen(array $row): bool will be called for custom empty row validation

It never gets called

How can the issue be reproduced?

implement SkipsEmptyRows, add isEmptyWhen(array $row): bool log something and/or return false and the method never gets called

What should be the expected behaviour?

isEmptyWhen should be called in the foreach loop on line 60 of Maatwebsite\Excel\Imports\ModelImporter

foreach ($worksheet->getRowIterator($startRow, $endRow) as $spreadSheetRow) {
            $i++;
            $row = new Row($spreadSheetRow, $headingRow, $headerIsGrouped);
            if (!$import instanceof SkipsEmptyRows || ($import instanceof SkipsEmptyRows && !$row->isEmpty($withCalcFormulas))) {
                $rowArray = $row->toArray(null, $withCalcFormulas, $formatData, $endColumn);

                if ($import instanceof SkipsEmptyRows && method_exists($import, 'isEmptyWhen') && $import->isEmptyWhen($rowArray)) {
                    continue;
                }
                
                if ($withValidation) {
                    $rowArray = $import->prepareForValidation($rowArray, $row->getIndex());
                }
            ...

Can I PR this? Not sure if that is the best way of doing it but the $rowArray isn't instantiated until after the initial if statement against instanceof SkipsEmptyRows. I can refactor that section a bit more if required?

[stale]

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

[touiminao]

Reopen

[typingbeaver]

It indeed seems to be ignored.

[sergejostir]

It works in version 3.1.51.