[Bug]: ErrorException: Undefined variable: sheetExport

[jerevive]

Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?

• Yes, it's still reproducable

What version of Laravel Excel are you using?

3.1.26

What version of Laravel are you using?

5.8.38

What version of PHP are you using?

7.3.33

Describe your issue

ErrorException: Undefined variable: sheetExport in /www/UserManagerTest/vendor/maatwebsite/excel/src/Jobs/QueueExport.php:76

How can the issue be reproduced?

    /**
     * @param Writer $writer
     *
     * @throws \PhpOffice\PhpSpreadsheet\Exception
     */
    public function handle(Writer $writer)
    {
        (new LocalizeJob($this->export))->handle($this, function () use ($writer) {
            $writer->open($this->export);

            $sheetExports = [$this->export];
            if ($this->export instanceof WithMultipleSheets) {
                $sheetExports = $this->export->sheets();
            }

            // Pre-create the worksheets
            foreach ($sheetExports as $sheetIndex => $sheetExport) {
                $sheet = $writer->addNewSheet($sheetIndex);
                $sheet->open($sheetExport);
            }

            // Write to temp file with empty sheets.
            $writer->write($sheetExport, $this->temporaryFile, $this->writerType);
        });
    }

What should be the expected behaviour?

norlmal

[horgolzari98]

The error you're encountering seems to be related to an undefined variable $sheetExport within the handle method of the QueueExport.php file. The error occurs specifically in this line:

$writer->write($sheetExport, $this->temporaryFile, $this->writerType);

It appears that there's a typo or a variable naming issue. The correct variable name should be $sheetExports (plural), as that is the array you defined earlier:

$sheetExports = [$this->export];

However, within the loop, you are iterating over $sheetExports (plural):

foreach ($sheetExports as $sheetIndex => $sheetExport) {
    $sheet = $writer->addNewSheet($sheetIndex);
    $sheet->open($sheetExport);
}

So, when you try to access $sheetExport outside the loop, it's undefined. To fix this issue, you should use $sheetExports instead of $sheetExport in the write method:

$writer->write($sheetExports, $this->temporaryFile, $this->writerType);

Here's the corrected version of the handle method:

public function handle(Writer $writer)
{
    (new LocalizeJob($this->export))->handle($this, function () use ($writer) {
        $writer->open($this->export);

        $sheetExports = [$this->export];
        if ($this->export instanceof WithMultipleSheets) {
            $sheetExports = $this->export->sheets();
        }

        // Pre-create the worksheets
        foreach ($sheetExports as $sheetIndex => $sheetExport) {
            $sheet = $writer->addNewSheet($sheetIndex);
            $sheet->open($sheetExport);
        }

        // Write to temp file with empty sheets.
        $writer->write($sheetExports, $this->temporaryFile, $this->writerType);
    });
}

Make sure to replace the problematic line with the corrected one, and the error should be resolved.

[jerevive]

Thank you for your answer, this part of the code is the source code, documents for maatwebsite/excel/SRC/Jobs/QueueExport. PHP, I directly modify the source code is not very good @horgolzari98

[patrickbrouwers]

Sounds like your sheets() method doesn't return sheet objects.

[jerevive]

I nested a layer of laravel job synchronously and put it on the queue and executed it on the cli @patrickbrouwers

[patrickbrouwers]

I'm not sure I understand what you mean. Can you show the code of the sheets() method

[patrickbrouwers]

Closing as this is a usage error. I've added a more explicit exception when this happens.