Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add window capture support #43

Closed
wants to merge 4 commits into from
Closed

add window capture support #43

wants to merge 4 commits into from

Conversation

adryzz
Copy link
Collaborator

@adryzz adryzz commented Oct 30, 2022

Closes #41

  • x11grab window capture
  • gdigrab window capture

@adryzz
Copy link
Collaborator Author

adryzz commented Oct 31, 2022

gdigrab works, although i've encountered a weird issue on the decoder thread where the calculation for how much time to sleep divides by 0 (e.g. decoder.Framerate.num is equal to 0)

image

@adryzz
Copy link
Collaborator Author

adryzz commented Oct 31, 2022

Apparently, the decoder frame rate is just a guess from FFmpeg, so when it's 0 we cam just fall back to a default value, as the worst that's gonna happen is a little higher CPU usage

@adryzz
Copy link
Collaborator Author

adryzz commented Oct 31, 2022

Apparently gdigrab cannot grab UWP windows...

https://trac.ffmpeg.org/ticket/7718

@adryzz
Copy link
Collaborator Author

adryzz commented Dec 10, 2023

i did not forget about this PR, finally gotten around to submitting the ffmpeg patch this depends on, we'll see how it goes from there

@adryzz
Copy link
Collaborator Author

adryzz commented Dec 17, 2023

WE ARE IN LETS GOOOOOOOOOOO

FFmpeg/FFmpeg@d7ac710

ill finally finish this pr lol

@adryzz
Copy link
Collaborator Author

adryzz commented Apr 15, 2024

welp it's definitely in mainline by now, time to update and stuff

@Speykious
Copy link
Owner

Seems like I got the time to make a complete rewrite PR before this one got updated. xD
I think it's best I close this one in favor of #51. Though I'm sure we can reuse all the interop code for GDI support.

@Speykious Speykious closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement window capture
3 participants