Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router constraints are useless #250

Closed
dkfellows opened this issue Aug 21, 2019 · 1 comment
Closed

Router constraints are useless #250

dkfellows opened this issue Aug 21, 2019 · 1 comment
Assignees
Milestone

Comments

@dkfellows
Copy link
Member

We have the module pacman.model.constraints.router_constraints which only defines a single abstract class, AbstractRouterConstraint, that nothing checks for or subclasses as a concrete class. Or even as another abstract class. It's use-less, and so is useless.

Can we delete the module? Defining a constraint using it will just result in that constraint being ignored; our routers don't roll that way.

@Christian-B
Copy link
Member

Done in #247

@dkfellows dkfellows modified the milestones: 5.1.0, 6.0.0 Nov 22, 2019
@dkfellows dkfellows modified the milestones: 6.0.0, 7.0.0 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants