build/libmaxmind.m4: fix build with host-pkgconf #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build with maxminddb is broken since version 3.0.5 and 785958f because libmaxminddb has been removed from MAXMIND_POSSIBLE_LIB_NAMES So, as suggested by Arnout in #2131, don't use MAXMIND_POSSIBLE_LIB_NAMES for pkg-config, because it was never called anything other than libmaxminddb Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Do you have some comments on this PR? |
|
No feedback? |
|
I suppose this looks reasonable. In a worst case we can revisit (or revert) if anyone reports it resulting in problems. Thanks @ffontaine. And also @arnout for making the original suggestion here: #2131 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with maxminddb is broken since version 3.0.5 and 785958f because
libmaxminddbhas been removed fromMAXMIND_POSSIBLE_LIB_NAMESSo, as suggested by Arnout in #2131, don't use
MAXMIND_POSSIBLE_LIB_NAMESfor pkg-config, because it was never calledanything other than
libmaxminddbSigned-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com