Move APLOG_USE_MODULE out of modsecurity.h #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting it in apache2.h solves the problem in a cleaner way |
I kind of agree, but my first try to solve it in a cleaner way failed, so I'm a bit cautious to add it again in a header file... |
|
Indeed, apache2.h (as most of other .h files) is inherited as well |
|
All right, this PR seems like a reasonable way to proceed. If no one raises any objections, I'll plan to merge this before the end of the day. |
|
Thanks @marcstern , for raising that detail on such a timely basis. And thanks @erkia for providing the adjustment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.