Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Add XSS checks for Referer header #606

Closed
lifeforms opened this issue Oct 5, 2016 · 3 comments
Closed

Add XSS checks for Referer header #606

lifeforms opened this issue Oct 5, 2016 · 3 comments

Comments

@lifeforms
Copy link
Contributor

We did some very basic work to add some XSS checks for the Referer header (#475) but were forced to pull some back because of trivial FP (#585).

It is still worthwhile to add more comprehensive XSS checks, but we have to do this more carefully, maybe make some PoCs, see how log viewers and clients handle this data, decide what kind of rules we can enable safely, and which transformations to use.

@lifeforms lifeforms added this to the CRS v3.1.0 RC1 milestone Oct 5, 2016
@lifeforms lifeforms changed the title Add XSS for Referer header Add XSS checks for Referer header Oct 5, 2016
@spartantri
Copy link
Contributor

@lifeforms, what if we add REQUEST_HEADERS:Referer to 941100 and close this issue?

@lifeforms
Copy link
Contributor Author

@spartantri We got burned by many false positives when trying to run libinjection on the Referer header, so we moved the Referer libinjection check to paranoia level 2 in #717.

(A combination of things happened here: libinjection used to be trigger happy on URLs, as it assumed that a string onfoo=bar was XSS. We brought it up with libinjection so that could be fixed now: client9/libinjection#115 But our transformations were also not being helpful here, as they made even more URLs match XSS. The litany was recorded in history here: #663)

@dune73
Copy link
Contributor

dune73 commented Feb 11, 2020

This has been open for far too long and it seems we are not able to come up with a decent solution that does away with the false positives that this brings. During the monthly CRS chat, we have does decided to close this issue.

Meeting minutes: #1671 (comment)

If anybody feels like giving this a go for real and come up with a working solution, then please reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants