Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS vendor prefixes from the .scss source #119

Closed
blackbaud-pacific opened this issue Jul 19, 2022 · 2 comments
Closed

Remove CSS vendor prefixes from the .scss source #119

blackbaud-pacific opened this issue Jul 19, 2022 · 2 comments
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.

Comments

@blackbaud-pacific
Copy link

It'd be great if you could remove the few remaining vendor prefixes (there's not many) in the sass source and let the end-user add these using an autoprefixer during build if needed.

I think this would just be a cleaner solution...as an example:
using Parcel as a build tool breaks the .form-group display.

To Reproduce
Compile CSS using Parcel (e.g. yarn start)
display: flex; display: -ms-flexbox;
is compiled to
display: -ms-flexbox;
...removing the original flex declaration.
(Easily fixed of course by using a utility class or overriding the style in index.scss.)

This is default Parcel behaviour and isn't a bug with Cirrus, but this problem could be avoided by leaving vendor-prefixing to the build tools.

Cheers :-)

@Spiderpig86
Copy link
Owner

Thanks for reporting this! I will take a look and see which prefixes are still needed and which are not using http://caniuse.com/. If there ends up being a few prefixes that are required, then I can write off the usage. If there are still a substantial number of browsers unable to support some CSS feature, then I am considering adding a flag to toggle vendor prefixes.

@Spiderpig86
Copy link
Owner

I have removed a sufficient amount of vendor prefixing except for 1 (this is done over a few commits, eff211e being the last one). I believe there shouldn't be any issues moving forward with using Parcel as the remaining ones are required to render pages correctly.

@Spiderpig86 Spiderpig86 added the pending release This issue has been looked at and resolved in code. It is now pending the next release. label Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
None yet
Development

No branches or pull requests

2 participants