Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard-code Google Fonts #99

Closed
phoerious opened this issue Mar 28, 2022 · 3 comments
Closed

Do not hard-code Google Fonts #99

phoerious opened this issue Mar 28, 2022 · 3 comments
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects

Comments

@phoerious
Copy link

phoerious commented Mar 28, 2022

The Nunito and Montserrat Google font @ imports are hardcoded in base/font.scss, which causes a lot of privacy and some performance issues. I would like to be able to host fonts myself and perhaps even use different fonts than the default ones.

@thepete89
Copy link

+1 for this, because it's especially important for people who reside inside the EU and in particular Germany from a legal standpoint. We have stringent data privacy laws (GDPR) here and more and more courts are ruling in such a way, that using anything directly from google (including google fonts!) without user consent is basically illegal.

My workaround right now is to remove/comment the imports out inside base/font.scss and add the fonts myself via fontsource later, but it would be great if we could tell Cirrus directly to use a local package/stylesheet or something similar. At least provide an option to disable those font-imports.

@Spiderpig86
Copy link
Owner

Thanks for the suggestion! I agree with this. The future update was going to introduce the ability to change fonts so this would fit very well. I'll add this on the roadmap for 0.7.1.

@Spiderpig86 Spiderpig86 added this to To do in 0.7.1 Apr 18, 2022
@Spiderpig86
Copy link
Owner

Resolved with dfaadb1

0.7.1 automation moved this from To do to Done Jun 1, 2022
@Spiderpig86 Spiderpig86 added the pending release This issue has been looked at and resolved in code. It is now pending the next release. label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
0.7.1
  
Done
Development

No branches or pull requests

3 participants