Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxiedPlayer chat function does not work in 1.19+ #3499

Open
3 of 4 tasks
MineFact opened this issue Aug 4, 2023 · 3 comments · May be fixed by #3506
Open
3 of 4 tasks

ProxiedPlayer chat function does not work in 1.19+ #3499

MineFact opened this issue Aug 4, 2023 · 3 comments · May be fixed by #3506

Comments

@MineFact
Copy link

MineFact commented Aug 4, 2023 •
edited

Bungeecord version

git:BungeeCord-Bootstrap:1.20-R0.1-SNAPSHOT:23fb838:1722

Server version

git-Paper-59 (MC: 1.20.1)

Client version

1.20.1

Bungeecord plugins

  • BungeeGuard
  • BTLP
  • ViaVersion

The bug

Since Minecraft version 1.19 the proxiedplayer.chat() function no longer seems to work.
When you use it on the latest server versions it always creates an error like this:

[13:54:31 WARN]: Error in dispatching command
java.lang.UnsupportedOperationException: Cannot spoof chat on this client version!
        at net.md_5.bungee.UserConnection.chat(UserConnection.java:449) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.buildtheearth.proxy.commands.socials.DiscordCommand.execute(DiscordCommand.java:91) ~[?:?]
        at net.buildtheearth.proxy.commands.Command.execute(Command.java:43) ~[?:?]
        at net.md_5.bungee.api.plugin.PluginManager.dispatchCommand(PluginManager.java:213) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.md_5.bungee.api.plugin.PluginManager.dispatchCommand(PluginManager.java:164) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.md_5.bungee.connection.UpstreamBridge.handleChat(UpstreamBridge.java:212) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.md_5.bungee.connection.UpstreamBridge.handle(UpstreamBridge.java:186) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.md_5.bungee.protocol.packet.ClientCommand.handle(ClientCommand.java:109) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]
        at net.md_5.bungee.netty.HandlerBoss.channelRead(HandlerBoss.java:114) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.20-R0.1-SNAPSHOT:ec41547:536]

One year ago someone mentioned this bug and md-5 said that chat spoofing is no longer supported. (#3327)
Other than that I couldn't find any info anywhere that this function should no longer be used.
After one year the chat function is still added with no warning of it being broken since 1.19+.

My request:
Could you either make the proxiedplayer.chat() deprecated or add a warning in the function documentation to no longer use it in the latest versions? Otherwise people will continue to have a hard time when trying to use that function and not knowing about the chat signing change in 1.19.

Log output (links)

No response

Checking

  • I am using BungeeCord and not a fork. Issues with forks should not be reported here.
  • I think this is not an issue with a bungeecord plugin.
  • I have not read these checkboxes and therefore I just ticked them all.
  • This is not a question or plugin creation help request.
@Janmm14
Copy link
Contributor

Janmm14 commented Aug 4, 2023

Feel free to fork this project, edit and create a PR for it.
https://github.com/SpigotMC/BungeeCord/edit/master/api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java#L189

@MineFact MineFact mentioned this issue Aug 4, 2023
Closed
@xism4
Copy link
Contributor

xism4 commented Aug 9, 2023 •
edited

Feel free to fork this project, edit and create a PR for it. https://github.com/SpigotMC/BungeeCord/edit/master/api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java#L189

To make that answer you can really save the comment, he followed all the steps to receive a proper answer.

@Janmm14
Copy link
Contributor

Janmm14 commented Aug 10, 2023

Feel free to fork this project, edit and create a PR for it. https://github.com/SpigotMC/BungeeCord/edit/master/api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java#L189

To make that answer you can really save the comment, he followed all the steps to receive a proper answer.

Given the issue is javadoc related, I do not see a problem asking the user to just actually edit it himself.

@MineFact MineFact linked a pull request Aug 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Janmm14 @MineFact @xism4