Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a few lints to clean up the code. Tests still pass.
The most notable change is that I have broken the public API,
recover_secret
now takes a slice rather than a Vec.A couple more things that I didn't fix but that should be addressed:
make_repeated_bytes_accessor
is deprecated. Any reason why that is still used?wrapped_secrets.rs:31
there is a weird for loop over anOption<String>
. Is that on purpose? What are you trying to do? I think you're better off withif let Some(mt)
rustfmt
One last thing, are you planning a release of the signed shares stuff?