Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the schema of naming librepair-experiments branches #403

Merged
merged 4 commits into from Feb 1, 2018

Conversation

surli
Copy link
Contributor

@surli surli commented Jan 31, 2018

branch name should not be identified by the patched buildid as we do not store it in the mongodb. Instead we should ALWAYS use the buggybuildid.

@surli
Copy link
Contributor Author

surli commented Jan 31, 2018

@monperrus I need your advice on this one: the current behaviour is to name branches on librepair experiments using either:

  • buggy build id + date of the bug + "bugonly" suffix, in case no human patch is found
  • patched build id + date of the patch, in case a human patch is found

The problem is, as I don't store the patched build id in the DB, I cannot easily find the associated branch of a buggy build if a patch has been found.
That should not be a problem in the future as we also store the URL of the remote branch in the DB, but still I find having two different pattern for naming branch confusing.

WDYT? Should we rely on the old pattern naming or should we change it now for future branches?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 53.664% when pulling 836b90d on change-branch-pattern into 05a7be2 on master.

@monperrus
Copy link
Contributor

monperrus commented Feb 1, 2018 via email

@surli
Copy link
Contributor Author

surli commented Feb 1, 2018

Is it possible to to do a massive renaming of old branches?

Yes it's possible. I could first merge the PR, start to use the new naming convention and then use a script to extract the buildid / date and rename from that.
We have to be absolutely sure about our naming format then.

@monperrus
Copy link
Contributor

monperrus commented Feb 1, 2018 via email

@surli surli merged commit c11ffbd into master Feb 1, 2018
@surli surli deleted the change-branch-pattern branch February 1, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants