Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to manipulate the pom-file before calling the maven invoker #855

Merged
merged 12 commits into from
Jul 11, 2019

Conversation

btellstrom
Copy link
Contributor

To be able to load snapshots and similar experimental tools, we will need to be able to tell repairnator to use non-maven-central repos. Currently, I am not aware of any way to load a custom pom-model into the invoker, and thus adding these repos into the pom before calling the maven-invoker seems to be the most simple way of doing this.

I put this into a separate PR since I will be adding some tests and messing with the configuration files, and it is a separate feature to NPEFixSafe, although at the moment necessary.

@btellstrom btellstrom added the WIP Issue or PR not ready for merging/closing label Jun 26, 2019
… Also adds a new repairstep to manipulate the POM-file of the cloned project.
@btellstrom
Copy link
Contributor Author

btellstrom commented Jul 4, 2019

It seems that evosuite.org is currently timeouting, which seems to lead to the build erroring due to taking too long. The job exceeded the maximum time limit for jobs, and has been terminated. is at the very end of the raw log.

@btellstrom
Copy link
Contributor Author

Do we have a flaky test?

Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.035 sec <<< FAILURE! - in fr.inria.spirals.repairnator.realtime.TestRTScanner
testRepositoryWithoutCheckstyleIsInteresting(fr.inria.spirals.repairnator.realtime.TestRTScanner)  Time elapsed: 3.101 sec  <<< FAILURE!
java.lang.AssertionError
	at fr.inria.spirals.repairnator.realtime.TestRTScanner.testRepositoryWithoutCheckstyleIsInteresting(TestRTScanner.java:49)


Results :

Failed tests: 
  TestRTScanner.testRepositoryWithoutCheckstyleIsInteresting:49

Tests run: 9, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] repairnator-root ................................... SUCCESS [ 13.592 s]
[INFO] repairnator-core ................................... SUCCESS [ 15.071 s]
[INFO] repairnator-pipeline ............................... SUCCESS [19:18 min]
[INFO] repairnator-scanner ................................ SUCCESS [02:09 min]
[INFO] repairnator-dockerpool ............................. SUCCESS [  4.604 s]
[INFO] repairnator-checkbranches .......................... SUCCESS [  3.286 s]
[INFO] repairnator-realtime ............................... FAILURE [ 14.983 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:26 min
[INFO] Finished at: 2019-07-05T11:41:14Z
[INFO] Final Memory: 148M/970M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project repairnator-realtime: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/travis/build/Spirals-Team/repairnator/repairnator/repairnator-realtime/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :repairnator-realtime
travis_time:end:057e3316:start=1562325526369763698,finish=1562326875272432247,duration=1348902668549
�[0K�[31;1mThe command "./.travis/travis-run.sh" exited with 1.�[0m



Done. Your build exited with 1.

@btellstrom
Copy link
Contributor Author

I believe the failing test might be because our test is relying on a repository that was recently updated, and where they specifically mention that they updated their checkstyle version 3 days ago.

nosan/embedded-cassandra

@btellstrom btellstrom added review PR ready for review/merge and removed WIP Issue or PR not ready for merging/closing labels Jul 10, 2019
@btellstrom
Copy link
Contributor Author

This PR should now be done.

@btellstrom btellstrom changed the title WIP Option to manipulate the pom-file before calling the maven invoker Option to manipulate the pom-file before calling the maven invoker Jul 10, 2019
@monperrus
Copy link
Contributor

LGTM but CI is red. How to fix this?

@btellstrom
Copy link
Contributor Author

The NPERepair test was failing, and I assume it's because I updated the version of maven-repair it is running. Updated the test accordingly now and if it doesn't work I'll revert the update (the version is only relevant for NPEFixSafe) and see if that works.

@btellstrom
Copy link
Contributor Author

One of our tests for checkstyle is currently faulty due to the repository recently starting to use checkstyle. I've ignored the test for now (it was passing before) but if we want to keep a test we should find a new repo that has the same desirable traits as it used to have.

@monperrus It should be done now.

@monperrus monperrus merged commit de1ff38 into master Jul 11, 2019
@monperrus
Copy link
Contributor

Thanks!

@monperrus monperrus deleted the manual-model-manipulation branch August 5, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review PR ready for review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants