Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Format for languages support #19

Closed
kazupon opened this issue Feb 26, 2019 · 6 comments
Closed

JSON Format for languages support #19

kazupon opened this issue Feb 26, 2019 · 6 comments
Projects
Milestone

Comments

@kazupon
Copy link
Contributor

kazupon commented Feb 26, 2019

Currently, AnalyzeLanguageFiles cannot read the json language files.
https://github.com/pixari/vue-i18n-extract#analyzelanguagefiles

We often use the json format.
I hope that supporting. :)

@pixari
Copy link
Collaborator

pixari commented Feb 26, 2019

Sure! I'll be easy.
Give me a couple of days. :)

@nelson6e65
Copy link

I just wanna point this, but I had not much time to test this tool in a project I used JSON.

Also... In addition... I don't use a key-like string ("message_title": "Título del mensaje") as key for the string in my JSON, but a "fallback" string as key ("Message Title": "Título del mensaje") (kazupon/vue-i18n#138 (comment))

@Spittal
Copy link
Owner

Spittal commented Feb 27, 2019

Also... In addition... I don't use a key-like string ("message_title": "Título del mensaje") as key for the string in my JSON, but a "fallback" string as key ("Message Title": "Título del mensaje")

This is the exact situation that I use. My keys are the fall back for my translations.

@pixari pixari added this to Backlog in Roadmap via automation Feb 27, 2019
@pixari pixari added this to the 1.0.0 milestone Feb 27, 2019
@pixari pixari changed the title [Feature Request] Support language json format JSON Format for languages support Feb 27, 2019
@pixari
Copy link
Collaborator

pixari commented Feb 27, 2019

The issue is in the roadmap now. 👍
My plan is to do it in 3/4 days.

I can start working on it, or maybe someone is already take care of it? (@Spittal?)

Thanks everybody.

@pixari
Copy link
Collaborator

pixari commented Feb 28, 2019

Hi @kazupon!

#25

@Spittal just fixed this issue. 👍 👍 👍

It's available in the latest version: 0.2.3.

We are also reviewing this PR:
#26

I think it adds an interesting feature.

😄

@pixari pixari closed this as completed Feb 28, 2019
Roadmap automation moved this from Backlog to Done Feb 28, 2019
@kazupon
Copy link
Contributor Author

kazupon commented Feb 28, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Roadmap
  
Done
Development

No branches or pull requests

4 participants