Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchAllForItemName method should search for Custom Name if available #10

Closed
ghost opened this issue Oct 8, 2015 · 1 comment
Closed

Comments

@ghost
Copy link

ghost commented Oct 8, 2015

We could still discuss if we want to add up a parameter on searchAllForItemName to override the default behavior of the method.

ie. If we implement automatic searching custom name if custom name is available, then we could add a parameter to force search the default name rather than custom name.

Tagging @Matrim-Cauthon and @SML-MeSo for your inputs on this one.

@ghost ghost added the enhancement label Oct 8, 2015
@ghost
Copy link
Author

ghost commented Oct 8, 2015

As per @SML-MeSo's suggestion, we would just fallback to using the actual name (getName), if the search keyword does not match with getCustomName. Assigning issue to me.

@ghost ghost self-assigned this Oct 8, 2015
@mikeybanez mikeybanez added this to the 0.8.0 milestone Oct 13, 2015
@ghost ghost added the ready-for-release label Oct 15, 2015
@ghost ghost closed this as completed in f53a4a2 Oct 21, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant