Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of functions #28

Closed
mikeybanez opened this issue Oct 16, 2015 · 0 comments
Closed

Inconsistent naming of functions #28

mikeybanez opened this issue Oct 16, 2015 · 0 comments
Labels
enhancement ready-for-release
Milestone
0.10.0

Comments

@mikeybanez
Copy link
Collaborator

In order to avoid any confusion, we should establish naming standards with our functions before we declare a stable version (1.X.X or higher) and start to avoid making breaking changes. Specifically, we should change all "getID" calls into "getId" as there is precedent in the native JavaScript function document.getElementById.

Any other inconsistencies should also be addressed in this issue.
@mikeybanez mikeybanez added this to the 0.9.0 milestone Oct 16, 2015
@mikeybanez mikeybanez mentioned this issue Oct 26, 2015
Closed
@mikeybanez mikeybanez modified the milestones: 0.10.0, 0.9.0 Oct 28, 2015
@mikeybanez mikeybanez modified the milestones: 0.11.0, 0.10.0 Nov 12, 2015
@mikeybanez mikeybanez assigned ghost Dec 10, 2015
@darklightblue darklightblue assigned darklightblue and unassigned ghost Dec 17, 2015
@SML-MeSo SML-MeSo modified the milestones: 0.10.0, 0.11.0 Jan 12, 2016
@ghost ghost closed this as completed in 0d7247c Jan 12, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ready-for-release
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@mikeybanez @SML-MeSo @darklightblue