Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Windows Title and Process Name don't work #242

Closed
manskou opened this issue Dec 19, 2016 · 11 comments
Closed

Active Windows Title and Process Name don't work #242

manskou opened this issue Dec 19, 2016 · 11 comments
Labels

Comments

@manskou
Copy link

manskou commented Dec 19, 2016

The first time I downloaded the update I set an Ambilight layer to be visible when my windows title contained 'YouTube'.
And it worked, for a while, after many restarts and a night later nothing works, I've set the process name to contain VLC and when I have vlc in focus, nothing happens.

Should I share some logs?

@DarthAffe
Copy link
Member

Yes, please add logs and if possible export the profile you use and add this too.

@RobertBeekman
Copy link
Member

RobertBeekman commented Dec 19, 2016

Looks to me as if it's not reflecting title updates to applications when they are in focus. Per example, Chrome changes it's window title when changing tab but this doesn't show in Artemis until you focus a different window and then focus Chrome again. The same goes for VLC, it adds the current filename to the window title but that's not shown until you shift focus to something else first.

LUA file that's useful for testing:

local update = 0;
-- This event is raised after every profile update, before drawing.
function updateHandler(profile, eventArgs)
    if eventArgs.DeviceType != "keyboard" then
        return
    end    

    -- Don't spam the logs
    update = update + 1;
    if (update < 40) then
        return
    end

    update = 0;
    print("Process: " .. eventArgs.DataModel.ActiveWindow.ProcessName);
    print("Title:   " .. eventArgs.DataModel.ActiveWindow.WindowTitle);
end

Events.DeviceUpdating.add(updateHandler);

@DarthAffe
Copy link
Member

Looks to me as if it's not reflecting title updates to applications when they are in focus.

It won't do this, that's right. I'll look into this, but

I've set the process name to contain VLC and when I have vlc in focus, nothing happens.

is a bit weird

@RobertBeekman
Copy link
Member

RobertBeekman commented Dec 19, 2016

Ah in Windows 10 it breaks when you do this:

  1. Focus VLC
  2. Click VLC in your task bar while it's focused, minimizing it.
  3. Click VLC in your task bar again, this brings the window back. Now it shows your previously active window in Artemis (in my case Chrome)

@DarthAffe
Copy link
Member

Same problem in windows 7 - I'll look into this too

@manskou
Copy link
Author

manskou commented Dec 19, 2016

so... i'm guessing there's no need for logs now right?

@DarthAffe
Copy link
Member

Well, could you re-test and verify that your issue is really the one we're describing here?
Everything should work fine if you un- and reselect vlc.

@manskou
Copy link
Author

manskou commented Dec 19, 2016

what do you mean by un and reselect?
a) bringing another window in focus and then focusing back to vlc?
or
b) minimizing vlc then opening it back up?

I'm at my pc rn, will be in ~an hour or less

@DarthAffe
Copy link
Member

bringing another window in focus and then focusing back to vlc?

Focusing a "new" window should always work.

The second one is a bug which needs to be updated first.

@manskou
Copy link
Author

manskou commented Dec 19, 2016

Found the problem, see issue #244

@RobertBeekman
Copy link
Member

I've pushed the update with these fixes included, thanks for the help everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants