[Enhancement] Basic keypress-controlled effects #276
Comments
|
Hello, some good ideas here, I've thought about 'guessing' what's going on by watching keyboard input but as you stated yourself it's very unreliable. This kinda matches with #254. I might not be able to do all of it but we'll see how it goes. (Won't be in the next update but keybindings and LightFX (such as LoL) support are my next point of focus after that) |
|
I've been wanting this. Also mouse input as well. Take this example of overwatch: https://www.youtube.com/watch?v=DD-y5cEsqrc Some of these affects would be great when your character is shooting, i.e. left mouse button is depressed. Think crazy pink ripples when DVA shoots or a slow yellow moving gradient when mercy heals. And slow moving blue on secondary fire (i.e right mouse button depressed). We could create a seriously awesome default profile for overwatch and other games with this. Granted, it would also do it on the hero selection screen when you are clicking around and not necessarily shooting -- as I'm guessing the game provides no hooks for this via the razer dll. But I'd certainly prefer it over not being able to do it. This is a simpler case than "toggles" trying to match game state I think. |
|
@adamscybot You could do most of the things in the video already by expanding the current Overwatch profile :) I'm currently a little low on time due to midterms but it's still the first thing on my list after the next release |
|
Here's a little preview of what I currently have. Alongside regular conditions you can now add key-press conditions. They work together with normal conditions. This means you can have a layer activate when a hotkey is pressed and a different condition is also met. You can toggle a layer on and off with the same key You can show a layer as long as you hold down a certain key, or combination of keys An example of how you can combine multiple keybinds. This layer activates after you press Ctrl+C and stays active until you press Ctrl+V |
|
This is great. So with this I could for example, apply an overlay when space is held but only when a certain hero on overwatch is set? Are mouse button bindings a possibility? |
|
This is amazing! When is it going to be added? |
|
@adamscybot yep, you could just combine this with another condition such as hero being Pharah. @Vanitied hopefully this week if nothing breaks |
|
Sounds really amazing. Also, how about that blinking/strobing effect. Also, a time modifier? Not sure if you can achieve those with these new additions, or even with lua. If that's the case, could you provide me with an example? |
|
Dont mean to piggyback on another thread, but is there a way to bring game conditions into a windows profile? |
|
@Vanitied not really, they are two fundamentally different things. What would the benefit of this be? |
|
Looking for feedback on this, please try the latest beta :) |
|
I am attempting to update to the pre release, which i assume you do by placing update.exe and "Release" in the artemis directory, but running Update.exe yields this in the squirrelssetup log.
Am i doing this completely wrong? |
|
Ah, sorry. The Update.exe is ran by Artemis itself so I had to include it. To use this, extract all files and run Artemis.exe in the Release folder |
|
OK. Progress. I am met with "Artemis has stopped working" whenever I run Artemis.exe in the release folder. |
|
Is this with Update.exe present one directory level higher? If it won't work I'll make a setup |
|
Hey, maybe my pc just has a gremlin. Test folder: update.exe, release |
|
Just extract it and run the exe, no need to worry about updating. That's how I did it. My feedback on the beta:
multiple times: and after a few mins it crashed Will test more and post again. |
Run/Attempt 1I tried making a new layer and set the keybind thing aaaaaand also this: And then Artemis crashed Run/Attempt 2No crashes yet, I made three layers, 1 was to become enabled when 1 is pressed, and disable when 2 or 3 are pressed, 2nd was to become enabled when 2 is pressed, and disable with 1 or 3, 3rd was when 3 is pressed, and disable when 1 or 2 are pressed. As it seems, Pressing 1, 2 ,3 enables and disables only the first layer. The culprit could be the way the keybinds are set up, they only hook to the first layer that u set them up with. Testing "Held Down"I set up a folder that enables when Z is pressed and lights up C and V with different colours, the only thing I noticed was that upon releasing Z, there would be a delay (I would guess 800-1000 ms) until the lights turn off. General FeedbackI think that some general keys like alt or shift could be added aswell, that way we could resolve #254 really well. I'm willing to make a custom profile for these modifiers if you like. Also, mouse functions (left click, right click, scroll button ect) should be added to the keybinds as well. |
|
Just an update on my situation: Debugging in Visual Studio leaves me with this: "An unhandled exception of type 'System.Windows.Markup.XamlParseException' occurred in PresentationFramework.dll Additional information: The invocation of the constructor on type 'Artemis.ArtemisBootstrapper' that matches the specified binding constraints threw an exception." |
|
@manskou Thanks for the feedback, I've fixed those crashes and I'm looking into a better way to do the held-down one. As for your example, setting up three layers like this works well for me: @Vanitied are you building x64? I've not had this issue myself. Does Artemis run fine when you run with with Ctrl+F5? |
|
Funnily enough I haven't actually downloaded the source files and tried to build like that. When I run it it crashes and Windows gives me two options, close, and debug, the latter of which opens VS and shows me the error. |
|
@SpoinkyNL Just tried re-opening the beta and doing what you did and each time I press the 1 button the the keybind I get there crashes, could you post another beta with the fix? EDIT: now I cant even open the beta Artemis, I get these crashes from start.... |
|
Please give this one a shot: artemis-1820-beta-2.zip I reworked the key-held keybind and got rid of the crashes, should work a lot better now |
|
Hold works fine, but the toggle-thing is a bit finicky. I set up a new profile with three layers configured as before (same as you did) and the problem presisted, pressing 1 or 2 was turning off the light, pressing 3 was turning on the 3rd layer's light. I decided to save the profile and send it to you, and while I was writing this response, it actually worked! Pressing 1 was enabling the 1st layer and disabling the others ect. So I went back to my default profile and recreated the set up and still nothing. I thought the profile was bugged or smth, so created a new profile, recreated the setup there and it still didn't work. Saved it, and still the same error. I honestly have no idea what's going on. Loading the profile that was working before does not produce the same error, it works fine. |
|
Hi, i've tried the latest Beta and adding the keybind is really cool. But i wanted to make a layer when i held down CTRL to light up ALT-TAB-C... you know all the combination. But the keybind don't work for CTRL key or ALT key. Would it be possible to add this key ? (I've probably not explain myself enought/well so don't hesitate to ask some question ;) ) |
|
@Baanor Ctrl, Alt and Win are modifiers, I currently can't bind just those sadly :c This sucks because having something light up when holding down Ctrl is a very valid use case. I'll look into it. Anyways, here's a new version with mouse binding support. I've done quite a bit of UI work in this one (together with me having next to no spare time atm, UI stuff is why it's taking so long) Please let me know how this one goes. It should be fairly release-worthy, aside from the modifier keys mentioned above. artemis-1820-beta-3.zip |
|
@SpoinkyNL Sniff... still it's not a must have. I think you have more important thing to see before that. And don't know if your still on your study but it's should be your priority (and good luck with it ;) ). I've tried the Beta 3, but the programm don't launch. I've tried it a second time cleaning old versions and conf and still nothing. It may be on my side, so i need to "reinstall" an older vesrions and tried it with full verbose mode to see what happen. |
|
Hehe yeah study + work makes for very little time left Did you extract everything so that the Update.exe is in place one folder higher than the rest? That's what can break it Make sure the folder layout looks like this
If it still doesnt work can you get me a log?
Thanks! |
|
@SpoinkyNL Yeah, that was that. I've directly take the release folder without update.exe... I feel dumb >< |
|
small feedback on the beta,
I will try creating a profile based on your new changes and game with it, then I'll post further feedback. Also, how do I use mouse events as hotkeys? I don't seem to find any option... Keybinds don't seem to work at all, here's a simple profile I made that doesn't work for me (delete the .txt in the end). |
|
Oh, I forgot to take those hotkeys out of the conditions section, they are ment to be used from the keybinds section below the conditions now, please give that a go |
|
Well then, it appears that I'm blind. The keybind section was right in
front of me and I simply ignored it 😂
A quick 1 minute test reroduced no errors, I will provide further feedback in
about half a day.
…On Thu, Mar 16, 2017, 12:03 AM Robert Beekman ***@***.***> wrote:
Oh, I forgot to take those hotkeys out of the conditions section, they are
ment to be used from the keybinds section below the conditions now, please
give that a go
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#276 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXetix9XKdUQaxKnzlP74PqHvxQ2ECKOks5rmGAtgaJpZM4LiECE>
.
|
Bugs/IssuesAfter extensive testing I figured out these:
Example where keybinds didn't work:
Then changed to this:
And it still didn't work OverallI think aside from the graphical glitches (mentioned in previous reply) I believe that the keybind implementation is really good. Thanks a lot for the time you've put into this!! |
|
Thanks for the feedback, helps a lot! I'll go through these tomorrow |
|
Here's one last beta, unless something is horribly broken this is the one I'll release tomorrow :) Meaning that if you keybind a folder to toggle on D and a layer inside of that folder to toggle on A, you'll have to press them both for the layer to show. Doesn't matter in which order you press them, they both need to be toggled Oh, and the UI glitches I found were the conditions going really wide and the window scrolling strangely with many layers active, I've fixed both |
|
Folders work normally now (our logic should be similar) but the "is event" thing still doesn't trigger with keybinds, I think a keybind keypress is an event and should be treated as such. I don't know if you tried implementing that but I think it adds meaningful extra functionality. Also, while toggling the Is Event switch I got this wierd error, the selection seems disabled. Toggling the switch fixes that.
All in all, keybinds in their current state are pretty darn good. I can't wait to see what other users do with them! |
|
Hey, if you setup a layer like so: It should trigger the pulse event (meaning it pulses once, until you press it again). If you also bind a condition to the event, it'll trigger either if the condition is matched or when you press the right mouse button, but if the condition is matched it will not trigger again until the condition is not longer matched (basically an event can only occur once per time it matches, else it would just keep repeating itself like a regular condition) Oh and when you toggle Is Event, it should lock the keybind into Enable and gray it out, however it seems to always gray it out, as seen on your screenshot, that's a bug |
|
This should enable the layer for 1000ms (1sec) and then disable it when I right click correct? because it doesn't work... Basically, a keypress should be treated as a normal event condition (i.e. changing the window), so the time expiration type will work. |
|
Yes, it should work like that, and in this version it actually does! 😅 I rewrote part of the event system and the one thing I forgot to test (timed expiration) was of course broken ^^ This version should behave as you described, if anything is still doesn't make sense please let me know then I'll look into it in the morning (01:00 here!) |
|
2:48 here hehe, Also, since most users would want to use the General profile, shouldn't it be Default when pressing the General tab, instaid of Bubbles? Anyway, this is going to be a major update and I'm very excited, thanks again for your work and goodnight! (or good morning since you're going to see that then...) |
I couldn't think of a better title, soo here's the deal:
In order to be able to make profiles for games without an RGB lighting API, some keypress-controlled effects should be made like the following:
On keypress, the key (or a key area) switches on and off rapidly, for a set amount of time, and then comes back to normal state (on or off)
Pressing the key, makes it (or a key area) toggle between different colors.
In case something happens and the order gets messed up (you die with weapon 2 and respawn with weapon 1, but the color is still A) the user can set a hotkey that will reset the order. Also, a "disable" (toggle/hold) key should be able to be set. i.e pressing T to open chat disables some layers... (but you wont be able to use the T key.... will have to think of something else instead...)
If those are something extremely difficult, for starters, I think you could implement the ability to enable or disable a layer with a keypress.
I think I had some more ideas but I don't seem to be able to recall them...
Anyways, hope you like 'em!
The text was updated successfully, but these errors were encountered: