Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Platform Version and Minecraft Version #294

Closed
n00b42 opened this issue Nov 3, 2017 · 11 comments · May be fixed by #949
Closed

Filter by Platform Version and Minecraft Version #294

n00b42 opened this issue Nov 3, 2017 · 11 comments · May be fixed by #949
Assignees
Labels
component: filter Filtering things on the home page or other places component: platform Platforms like Sponge / Forge component: tags New Tag or having to do with the Tag System priority: high type: enhancement
Milestone

Comments

@n00b42
Copy link

n00b42 commented Nov 3, 2017

  • Filter by Minecraft Version
  • Filter by Sponge API Version
@ryantheleach
Copy link
Contributor

ryantheleach commented Nov 3, 2017

To effectively add this I think we need more support for specifying a range of versions that a release will work on.

I'd suggest filtering by Sponge API only.

Minecraft Version, if added, can just be a parent category of Sponge API version if we go down that route.

@phase
Copy link
Contributor

phase commented Dec 31, 2017

This should be included with the Tag system I described in #307.

@bloodmc
Copy link

bloodmc commented Jan 28, 2018

Yes this needs to be done as the average user will have no idea what Sponge API version means. It's ok for it to be included somewhere but the main search should be by MC version.

@phase phase changed the title Feature Suggestion: More Filter Filter by Sponge API and Minecraft Version Aug 23, 2018
@phase
Copy link
Contributor

phase commented Aug 23, 2018

@ryantheleach said

It should be Minor / Patch version aware, so if a plugin is uploaded with a 4.1 dependency, that would not show on a 4.0.0 filter.

However a 4.0.0 plugin would show on a 4.1 filter.

👍 on that

he also offered this mockup for a first time user

@phase phase added component: filter Filtering things on the home page or other places and removed component: backend component: frontend labels Aug 23, 2018
@phase
Copy link
Contributor

phase commented Aug 23, 2018

Minecraft Versions are waiting on SpongePowered/DownloadIndexer#7

@phase phase self-assigned this Aug 25, 2018
@phase phase added the component: platform Platforms like Sponge / Forge label Aug 25, 2018
@phase phase changed the title Filter by Sponge API and Minecraft Version Filter by Sponge and Minecraft Version Sep 18, 2018
@phase
Copy link
Contributor

phase commented Sep 18, 2018

I'm adding SpongeForge, SpongeVanilla, & SpongeCommon filtering to this issue too.
See the discussion in SpongePowered/SpongeForge#2367

@gabizou
Copy link
Member

gabizou commented Sep 20, 2018

Will be able to filter by sponge implementation versions too, if a plugin depends on a specific sponge common (to work on sponge vanilla or sponge forge).

@phase phase changed the title Filter by Sponge and Minecraft Version Filter by Platform Version and Minecraft Version Sep 21, 2018
@phase
Copy link
Contributor

phase commented Sep 21, 2018

changing the title again just for the fun of it

Changing the scope of this issue again to encompass all platform version filters, as I will do them all at the same time. Every platform will have an associated version parser.

Long version strings will be shortened. Things like -SNAPSHOT are long and foreign to users. I think we should replace 8.0-SNAPSHOT with 8.0* or something similar (maybe the star can be blue or some different color?) to differentiate it from a normal version. Same goes for the new Sponge implementations' RC.

Platform Version Pattern Version Example Notes
Sponge API MAJOR.MINOR(.PATCH)?(-SNAPSHOT)? 8.0 Patch won't exist for 8.0 and onward.
Sponge Common MCVER-MAJOR.MINOR.RC(-SNAPSHOT)? 1.12.2-8.0.2 We need to support old & new patterns
Sponge Forge MCVER-FORGEVER-MAJOR.MINOR.RC(-RC##)? 1.12.2-2705-7.1.4 We need to support old & new patterns
Sponge Vanilla MCVER-MAJOR.MINOR.RC(-RC##)? 1.12.2-7.1.4 We need to support old & new patterns
Lantern MCVER-MAJOR.MINOR.RC(-RC##)? 1.12.2-7.1.4 Same as SpongeVanilla, won't go into affect for a bit but it should be fine to use it now.
Forge MAJOR.MINOR.PATCH.BUILD 14.23.4.2705 Confirm the format?

A translation from Platform Version to Minecraft Version will be added for platforms that don't have the MC version in the format.

@phit
Copy link

phit commented Sep 21, 2018

can we add mc version to forge? should be easy to get from the version number just needs a table, i.e. when:
14.21 > 1.12
14.22 > 1.12.1
14.23 > 1.12.2

and add this in from of the version, example 1.12.2-14.23.4.2705

also i dont agree with making snapshot just a small star, for all i care make it a big red warning, you really shouldnt depend on snapshots

@phase
Copy link
Contributor

phase commented Sep 21, 2018

We could put the MC version somewhere else so that the tag is smaller.

@Katrix Katrix added the component: tags New Tag or having to do with the Tag System label Jan 11, 2019
@Katrix Katrix modified the milestones: v2.0.x, v2.0.0-M3 Jan 26, 2020
@Katrix
Copy link
Member

Katrix commented Mar 27, 2020

Now supported with the new Vue frontend

@Katrix Katrix closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: filter Filtering things on the home page or other places component: platform Platforms like Sponge / Forge component: tags New Tag or having to do with the Tag System priority: high type: enhancement
Projects
None yet
8 participants