New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files in non-reviewable channels should not be marked as recommended #520

Open

dualspiral opened this issue Apr 7, 2018 · 1 comment · May be fixed by #949

Labels

status: input wanted

Milestone

Contributor

dualspiral commented Apr 7, 2018

If a file is in a non-reviewable channel, then it should not be marked as recommended. It is currently the cas that they can be.

Thoughts on what could be done:

Recommended builds should always be candidates for review, and should ignore the channel flag
Files in non-review channels should not have the option to "set recommended"
A file that is set as recommended and then marked as non-reviewable should have the recommended flag revoked

I don't know if a file must always be recommended, if so, the simplest approach is the first option. Depends what @progwml6 and @mbax think.

mbax commented Apr 8, 2018

I like option one, except don't display recommendation to users until approved.

ryantheleach added the status: input wanted label

Katrix mentioned this issue

Replace a third of Ore #930

Closed

Katrix added this to the v2.0.0-M3 milestone

Katrix linked a pull request

that will close this issue

Vue frontend for Project area (and other stuff) #949

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment