Entities rendering incorrectly due to DataEntry value not updating

[XXMA16]

Affected Product(s)

SpongeForge, SpongeVanilla

Version

spongevanilla-1.16.5-8.2.0

Operating System

Windows

Java Version

jbrsdk jcef 17.0.9

Plugins/Mods

No additional mods or plugins

Describe the bug

Any mob whose rendering calls entity.isAggressive() (i.e. Skeletons and Drowned with Tridents) will have an incorrect pose while attacking due to said method call returning false (when it should be true). This happens because of an @Overwrite here. Without any plugins the value will always be retrieved from converter.get().getValueFromEvent(currentValue, event.endResult()) which will return currentValue, thus discarding the incomingValue and telling the client the mob is not aggressive while attacking.

Although I have not done extensive testing, this bug seems to affect the following versions (and almost certainly any version between them, both Forge and Vanilla):

• spongevanilla-1.16.5-8.2.0
• spongeforge-1.16.5-36.2.5-8.2.0
• spongevanilla-1.19.4-10.0.0-RC1469
• spongevanilla-1.20.2-11.0.0-RC1471

spongevanilla-1.12.2-7.4.8-RC427 is not affected

Link to logs

No response