THROWER and PROJECTILE_SOURCE EventContextKeys

[RedNesto]

During the implementation of the LaunchProjectileEvent, I saw there were two EventContextKeys that can be used for the same event: THROWER and PROJECTILE_SOURCE.

What is the difference between these?

I don't see any to be honest. For me, PROJECTILE_SOURCE is more general than THROWER (which may imply a projectile launched by hand to me, but still a projectile), so if we need to remove one, I would remove THROWER.

[ImMorpheus]

From what I see, PROJECTILE_SOURCE is only used here as the second parameter of the method handleCollideImpactEvent.
This method is called:
MixinEntityThrowable with the argument this.getShooter()
MixinEntityArrow with the argument getShooter()
MixinEntityFireball with the argument this.getShooter()

But, when added as a context key in the CSM getShooter() is always the EventContextKeys.THROWER: MixinEntityLargeFireball, MixinEntityWitherSkull, MixinEntityFireworkRocket, ...

So, yeah... They represent the same thing.

[Zidane]

We need to just go with Projectile_Source for API 8.

[ryantheleach]

Should we deprecate thrower asap then, with the note that Projectile_Source replaces it in API 8 ?

[parlough]

This has been solved with #1779