Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Entity Spawning Example #427

Closed
ghost opened this issue Jan 10, 2016 · 5 comments
Closed

Verify Entity Spawning Example #427

ghost opened this issue Jan 10, 2016 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 10, 2016

See this forum post for the problems that arose with it.

We need to verify if it was an error on nap's part or if the EntitySpawnCause.builder() is not included in 3.0.0

@ghost ghost added the factual error The documentation contains some false statements/examples label Jan 10, 2016
@ghost ghost self-assigned this Jan 10, 2016
@ghost ghost removed the factual error The documentation contains some false statements/examples label Jan 10, 2016
@12awsomeman34
Copy link
Contributor

Time to blame @12awsomeman34...

I ran some tests using the builder, and can reproduce the same error.
It would seem that the EntitySpawnCause.builder() is meant for use by sponge, not so much for plugins (please correct me if I'm wrong, basing this off of the fact that there is an error when using it).

I'm not entirely sure if Cause.of(this) is a great substitute for a Cause, seeing as Cause.of() will accept any Object, however it seems to work.

Progress on this can be tracked in the fix/spawning branch.

See below.

@gabizou
Copy link
Member

gabizou commented Jan 10, 2016

EntitySpawnCause.builder() is supposed to be implemented, just hasn't been properly implemented and registered. SpawnEntityEvents are still fubared in this case because when they were initially implemented, they weren't implemented with any use of SpawnCauses of any kind.

@napentathol
Copy link

The version of sponge I am using is 1.8-3.0.0-BETA-129
The version of the api I am using is 3.0.0

@12awsomeman34
Copy link
Contributor

@gabizou
Thanks for the clarification, does this mean the issue is invalid?

@gabizou
Copy link
Member

gabizou commented Jan 10, 2016

IT's invalid for the docs, but not for the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants