fix: Remove v prefix in Dockerfile and Github Action _VERSION variables
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE, without that limitation, and enabling regexManagers:helmChartYamlAppVersions Renovate will be remove `v` prefix, no matter is it needed or not
MaxymVlasov
force-pushed
the
fix/Dockerfile_v_prefix
branch
from
cee85f4
to
86bcb7f
Compare
…duced later" This reverts commit 86bcb7f. >"\"fileMatch\" must be configured in a manager block and not here: packageRules[1]"
MaxymVlasov
changed the title
v prefix in regex _VERSION variablesv prefix in Dockerfile and Github Action _VERSION variables
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
## [1.2.1](v1.2.0...v1.2.1) (2023-03-24) ### Bug Fixes * Remove `v` prefix in Dockerfile and Github Action `_VERSION` variables ([#64](#64)) ([5910fc0](5910fc0))
|
This PR is included in version 1.2.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that applies:Description of your changes
v1.2.0 says that it introduces the removal of
vprefix in_VERSIONvariables for Dockerfiles, but eventually, it did not work.This PR fixes it and makes able to avoid the addition of not needed
vprefix for_VERSIONin Github Actions too.How was it tested
Test repo with Enable Renovate and 2 files in repo root:
renovate.json5with the same settings as in this PRDockerfile with stuff like: