Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic state in player listener #23

Open
thejeancarton opened this issue Feb 11, 2024 · 27 comments
Open

Panic state in player listener #23

thejeancarton opened this issue Feb 11, 2024 · 27 comments

Comments

@thejeancarton
Copy link

[java.lang.UnknownError: PanicState in PlayerListener] com.spotifyxp.listeners.PlayerListener.onPanicState(PlayerListener.java:206)
com.spotifyxp.deps.xyz.gianlu.librespot.player.Player$EventsDispatcher.lambda$panicState$14(Player.java:1232)
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
java.base/java.lang.Thread.run(Thread.java:1589)
@werwolf2303
Copy link
Contributor

werwolf2303 commented Feb 18, 2024

Sorry for the late response. I was feeling worse again... mentally.
Anyway.....

When does this happen?

@lesar8
Copy link

lesar8 commented Feb 18, 2024

I got this error too, randomly but occasionally, after auto or manual switch to different track. It also comes along with this error:

[java.util.concurrent.RejectedExecutionException: Task com.spotifyxp.deps.xyz.gianlu.librespot.audio.cdn.CdnManager$Streamer$InternalStream$$Lambda$185/22406510@8cb47 rejected from java.util.concurrent.ThreadPoolExecutor@195298b[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = *]]

Worse, sometimes SpotifyXP keep showing this message "Couldn't get default token" and I need to relaunch it to play music.

abc

@werwolf2303
Copy link
Contributor

I should test SpotifyXP more often on Windows XP instead of MacOS. I will inform you when there is a fix available for these issues. The only thing that's confusing me is the "Couldn't get default token", this should not happen. Weird but I will try to find out the cause

@werwolf2303
Copy link
Contributor

Can you post the exception you got on the "Cannot get default token". That would be very helpful

@lesar8
Copy link

lesar8 commented Feb 20, 2024

Can you post the exception you got on the "Cannot get default token". That would be very helpful

It's kinda impossible to click to the errors dialog because the Info message keep poping up all the times lol.. I tried, sorry..

abc

@werwolf2303
Copy link
Contributor

werwolf2303 commented Feb 21, 2024

Please open cmd and execute this inside the folder where the SpotifyXP.jar is: "java -jar SpotifyXP.jar --setup-complete --debug". And post a screenshot of the cmd after this error came up

@lesar8
Copy link

lesar8 commented Feb 22, 2024

Got no luck today, I've been testing for more than 5 hrs but the "Couldn't get default token" doesnt trigger yet.. (it's rarely triggered). On the other hand, i got the debug log (copied from the Command line) for "Panic state in player listener" and "[java.lang.IndexOutOfBoundsException Index 0, Size 0]" error.

PanicState in PlayerListener.txt
[java.lang.IndexOutOfBoundsException Index 0, Size 0].txt

The "IndexOutOfBoundsException" is a nasty error that I forgot to tell you. Song will stop playing and relaunch required. I will do the test tomorrow and hope for the "token" error trigger.

@werwolf2303
Copy link
Contributor

Ok thanks I will try to fix them

@werwolf2303
Copy link
Contributor

Does the issue still persist in the newest nightly?

@lesar8
Copy link

lesar8 commented Mar 6, 2024

Does the issue still persist in the newest nightly?

Unfortunately it's still throwing the same error as mentioned above. Here is a debug log, hope it help.

PanicState in PlayerListener.txt

[java.lang.IndexOutOfBoundsException Index 0, Size 0] .txt

@werwolf2303
Copy link
Contributor

werwolf2303 commented Mar 6, 2024

There are a lot of "socket timed out" errors. What type of internet do you have(fiber optic, DSL, VDSL, ADSL, Dial-Up)? What internet card do you have in this device?

@lesar8
Copy link

lesar8 commented Mar 6, 2024

There are a lot of "socket timed out" errors. What type of internet do you have(fiber optic, DSL, VDSL, ADSL, Dial-Up)? What internet card do you have in this device?

I using adsl connection and onboard Realtek ethernet. When I switch to 4G connection (via USB), the same error is still happens so I don't think it's related to internet type and device.

@werwolf2303
Copy link
Contributor

werwolf2303 commented Mar 6, 2024

Ok so then it isn't your internet type... Maybe it's that your connection is unstable. Can you check that with: "speedtest.net" please give me the results afterwards

@lesar8
Copy link

lesar8 commented Mar 6, 2024

Ok so then it isn't your internet type... Maybe it's that your connection is unstable. Can you check that with: "speedtest.net" please give me the results afterwards

Here it is: https://www.speedtest.net/result/15974846970

My internet is very stable (i have wired connection), i don't have any problems at all watching videos or browsing or even downloading

@werwolf2303
Copy link
Contributor

Ok same internet type and speed as me. So it is definitely not your internet... I have to look more into this "socket timed out" thing.

@lesar8
Copy link

lesar8 commented Mar 6, 2024

Ok same internet type and speed as me. So it is definitely not your internet... I have to look more into this "socket timed out" thing.

This "IndexOutOfBoundsException" error is very odd, everytimes I play song it's immediately throw an error on "Errors" dialog and force me to re-launch SpotifyXP. This feel like something related to SpotifyXP itself, not Spotify server.

@werwolf2303
Copy link
Contributor

I only require a user to restart SpotifyXP if it's a critical non recoverable error

@werwolf2303
Copy link
Contributor

werwolf2303 commented Mar 6, 2024

When I have time I will add a "Continue? SpotifyXP is maybe unstable" similar to old windows

@lesar8
Copy link

lesar8 commented Mar 6, 2024

I only require a user to restart SpotifyXP if it's a critical non recoverable error

Well sorry for wrong choice of word, i actually mean the "IndexOutOfBoundsException" error prevent track (all of them!) to be play so I need to re-launch SpotifyXP.

@werwolf2303
Copy link
Contributor

I will research this and come up with a fix

@werwolf2303
Copy link
Contributor

Please check if this is fixed in the newest nightly build

@lesar8
Copy link

lesar8 commented Apr 12, 2024

Unfortunately I'm still getting the 'Panic state' and 'IndexOutOfBoundsException' errors in the newest nightly build.

@werwolf2303
Copy link
Contributor

I found out why the fix wasn't working :) I didn't upload it.... LOL

@werwolf2303
Copy link
Contributor

Please check if this error still happens

@lesar8
Copy link

lesar8 commented Apr 16, 2024

Well.. it's still happening and also comes along with a new error "Java.Net.SocketException: Socket closed".

Screenshot and debug log attached.
error

Debug Log.txt

@FlorianisonGitHub
Copy link

Will SpotifyXP get any better?

@werwolf2303
Copy link
Contributor

werwolf2303 commented May 10, 2024

The underlying library that I'm using was apparently never designed to run in the backend so I had to modify a lot of it to get to the state that SpotifyXP is today. I'm still fixing issues if I find any. So to answer your question: Yes, SpotifyXP will become better but this will take it's time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants