Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings during cargo check in macos-latest target #801

Closed
CPerezz opened this issue Jan 31, 2021 · 3 comments
Closed

Warnings during cargo check in macos-latest target #801

CPerezz opened this issue Jan 31, 2021 · 3 comments
Labels
bug A functionality or parts of a program that do not work as intended

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Jan 31, 2021

While running the CI in #800 the following was spoted.

Checking spotifyd v0.3.0 (/Users/runner/work/spotifyd/spotifyd)
warning: field is never read: `volume_controller`
Warning:    --> src/config.rs:594:5
    |
594 |     pub(crate) volume_controller: VolumeController,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: 1 warning emitted
Warning: 1 warning emitted
```

I think it would be a `good first issue` for new rustaceans.

@CPerezz CPerezz added the bug A functionality or parts of a program that do not work as intended label Jan 31, 2021
@oriolval
Copy link

oriolval commented Feb 1, 2021

Let's go, I will be busy for the next days solving this issue. Thanks mate!

@robinvd
Copy link
Contributor

robinvd commented Feb 8, 2021

should i assign you @oriolval

@CPerezz
Copy link
Contributor Author

CPerezz commented Feb 9, 2021

Sorry. This is a leftover of my work on #800. I mistakenly understood that the warn was there before when indeed it was produced by my conditional compilation code added.

I fixed this by adding:

#[cfg_attr(not(feature = "alsa_backend"), allow(dead_code))]
    pub(crate) volume_controller: VolumeController,

So I think this can be closed.
Sorry for the noise @oriolval and @robinvd

@CPerezz CPerezz closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A functionality or parts of a program that do not work as intended
Projects
None yet
Development

No branches or pull requests

3 participants