-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Unnecessary recompiling spdlog-rs #40
Labels
bug
Something isn't working
Comments
Thanks for your report! I have opened a PR #41 to fix the bug. |
Released in v0.3.12. |
@SpriteOvO that is awesome. Thanks for the fast fix. I will check it out. ✨ |
It is indeed working:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Running
cargo build
back to back compiles spdlog-rs on both iterations.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The first build should download and compile all dependencies. The second build should finish without compiling anything.
Environments
Additional context
Running >
cargo build --verbose
shows thattarget\debug\build\spdlog-rs-29fb83146f549d72\out\test_utils\common_for_doc_test.rs
is dirty.Additionally, has the spdlog-rs{id}/output fil the following lines, which is causing the rebuild.
The text was updated successfully, but these errors were encountered: