Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Inconsistent Player Ordering in Round Embed #61

Closed
TylerBloom opened this issue Nov 19, 2022 · 1 comment
Closed

[Bug]: Inconsistent Player Ordering in Round Embed #61

TylerBloom opened this issue Nov 19, 2022 · 1 comment
Assignees
@TylerBloom
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TylerBloom
Copy link
Member

What went wrong:

Between constructions of the Round status embed, the player order can change. This stems from the Round storing players in a HashSet.

Expected behavior:

This ordering should be consistent.

General Info:

There is an issue out in SquireLib (Rounds Track Player Order) that will help remedy this.
@TylerBloom TylerBloom added bug Something isn't working good first issue Good for newcomers todo Will be resolved but work hasn't started labels Nov 19, 2022
@TylerBloom
Copy link
Member Author

The required changes to SL are implemented. This should be straightforward to implement.

@TylerBloom TylerBloom self-assigned this Nov 28, 2022
@TylerBloom TylerBloom removed the todo Will be resolved but work hasn't started label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerBloom TylerBloom

Labels
bug Something isn't working good first issue Good for newcomers
Projects
Squire Tournament Services
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerBloom