Per-machine installer downgrades application upgraded by silent install.

[skaryshev]

Found in 1.2.2. Steps to reproduce:

1. Install application version 1 by per-machine installer
2. Build new release version 2
3. Run application to let silent install upgrade to version 2
4. Logout. Login. Find application downgraded to version 1 (by per-machine installer I guess)

[davidpsaylor]

I've had the same issue. Is there a suggested workaround?

[anaisbetts]

Hm, I'm not seeing this. Does this happen with the MSI file?

[skaryshev]

I releasify version 1 of App. Install MSI and re-login. Now App v1 is installed by per-machine install.
I releasify version 2 of App and run App. Now App v2 is installed by silent install.
I re-login and and the per-machine installer runs and installs App v1 again.

[anaisbetts]

Hm, I just did exactly that with Slack and it worked. Did you change your NuGet Package ID in an update or something crazy?

[skaryshev]

I am looking through the code and MachineInstaller::ShouldSilentInstall should take care of my case and prevent install if C:\Users\Username\AppData\Local$pkgName\packages dir exists. Will rebuild and try again and rebuild debug and try again....

[skaryshev]

I think I found something:
src/Setup/MachineInstaller.cpp in bool MachineInstaller::ShouldSilentInstall() on line 140
installFolder is like C:\Users\Username\AppData\Local\$pkgName\packages
Note double backslash before pkgName. Because
CString pkgName = CString(ourFile + fullPath.ReverseFind(L'\\'));
returns a leading backslash and
wcscat(installFolder, L"\\"); on line 135 adds another backslash.
Anyway MachineInstaller::ShouldSilentInstall() does not work for me as expected and returns true when we're already installed.

[skaryshev]

Found it! My problem was a dot in my package ID. I soon as I changed Package.Name to Package_Name the issue was resolved even with double backslash still in the path.
Thank you.

[SlySven]

Found it! My problem was a dot in my package ID. I soon as I changed Package.Name to Package_Name the issue was resolved even with double backslash still in the path. Thank you.

Hang on - this is exactly the opposite of what the nuget documentation says: https://learn.microsoft.com/en-us/nuget/create-packages/creating-a-package#choose-a-unique-package-identifier-and-setting-the-version-number where it says to use '.' rather than '-' or '_' to separate components!