Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Assembly name has spaces shortcuts wont work #713

Open
jordyvaneijk opened this issue May 26, 2016 · 3 comments
Open

When Assembly name has spaces shortcuts wont work #713

jordyvaneijk opened this issue May 26, 2016 · 3 comments

Comments

@jordyvaneijk
Copy link

jordyvaneijk commented May 26, 2016

If I have a space in my Assembly name (I.E.: Hello World) then my applications executable will be Hello World.exe When the startmenu shortcuts are created the Taget at that time will be something like:
C:\PathToApplication\Update.exe --processStart Hello World.exe
This will give the following exception while trying to start the application from the startmenu

2016-05-26 09:24:57> Program: File C:\PathToApplication\app-1.0.0.3\Hello doesn't exist in current release
2016-05-26 09:24:57> Unhandled exception: System.ArgumentException: Value does not fall within the expected range.
at Squirrel.Update.Program.ProcessStart(String exeName, String arguments, Boolean shouldWait)
at Squirrel.Update.Program.executeCommandLine(String[] args)
at Squirrel.Update.Program.main(String[] args)

This can be fixed by putting puting qoutes around the executables name in the Target of the shortcut C:\PathToApplication\Update.exe --processStart "Hello World.exe". Maybe this can be fixed?

@hermyt
Copy link

hermyt commented Jul 9, 2016

Tested this and same issue, checked around and noted that this has been reported and reported fixed a few times but it still seems to be an issue and is easy to repeat.

  1. Create a new windows forms solution with a space in the solution name
  2. add squirrel package
  3. create nupkg
  4. squirrel releasify
  5. run setup.exe
  6. app will run the first time but shortcut is broken with no quotations for the assembly name with a space, manually correcting the shortcut makes it work until an update.

Attempted to change application to 'SquirrelAwareVersion' and manually call events and CreateShortcutForThisExe's but effect was the same. Calling the CreateShortcutsForExecutable with an override exe reference produces the same and attempting to add in 'quotation' marks to the function call results in no creation of shortcuts.

The only real solution at the moment appears to be changing your assembly name to remove spaces.

@Thieum
Copy link
Contributor

Thieum commented May 3, 2019

Consider the PR #1401 that attempts to fix this issue.

@Thieum
Copy link
Contributor

Thieum commented May 3, 2019

Consider also the possible back and forth with %20 in #1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants