Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider for updating the column and row for the Color Grid #4

Open
SscSPs opened this issue Oct 8, 2022 · 18 comments
Open

Add slider for updating the column and row for the Color Grid #4

SscSPs opened this issue Oct 8, 2022 · 18 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Recommended Issues for trying out PR creation for Hacktober fest help wanted Extra attention is needed

Comments

@SscSPs
Copy link
Owner

SscSPs commented Oct 8, 2022

The grid currently have fixed rows and column count,
we should add sliders for them so user can control it.

@SscSPs SscSPs added enhancement New feature or request help wanted Extra attention is needed Hacktoberfest Recommended Issues for trying out PR creation for Hacktober fest labels Oct 8, 2022
@webcoderspeed
Copy link
Contributor

Hey bro, can I pick this up. Also your code is using class based components I you don't mind can I change them to functional based component

@00sukhjeet00
Copy link

Hey I can add the slider for updating the columns and row for the color grid.
I have one query the row and columns should remain same or they can be updated individually.

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

I think they should be controllable seperately, but if you find single control better, then you may implement that.
Think about how a user might want it to be so they have better control over the app.

Should I assign this to you?

@00sukhjeet00
Copy link

Yeah sure

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

You may convert it to functional components, i created it some time ago, and i don't remember why I picked class based

@00sukhjeet00
Copy link

I can continue it in class base also. As you wise @SscSPs

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

@webcoderspeed please create an issue for "functional components" and you can work on that, i suppose this can be done by @00sukhjeet00

@00sukhjeet00
Copy link

Yeah sure not an issue. Thanks assigning

@SscSPs SscSPs assigned SscSPs and 00sukhjeet00 and unassigned SscSPs Oct 8, 2022
@00sukhjeet00
Copy link

@SscSPs Should I start working with class based or wait for @webcoderspeed to create functional based component and then start working on slider

@webcoderspeed
Copy link
Contributor

I have created a issue #11 for converting class to functional components

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

Awesome!

You two please discuss with each other based on when you want to work on your tasks to clarify the timelines,
One needs to be done after another, either can be before othe other one.

@00sukhjeet00 @webcoderspeed whichever one takes less time can be done earlier and the other person can start after that or tomorrow

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

On second thought, i think component conversion should be first, to have less work for conversion

@webcoderspeed
Copy link
Contributor

@00sukhjeet00 let me first complete the conversion from class based to functional and then after that

@00sukhjeet00
Copy link

Okay, @webcoderspeed Thanks for conformation.

@webcoderspeed
Copy link
Contributor

#11 @00sukhjeet00 bro you can proceed after the merge

@00sukhjeet00
Copy link

Yeah sure

@SscSPs
Copy link
Owner Author

SscSPs commented Oct 8, 2022

@00sukhjeet00 #11 was merged some time ago, you can work on this as you get time

@00sukhjeet00
Copy link

00sukhjeet00 commented Oct 9, 2022

Okay @SscSPs

@SscSPs SscSPs added the good first issue Good for newcomers label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Recommended Issues for trying out PR creation for Hacktober fest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants