Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove indexed keyword from onlyOwner events #11

Open
StErMi opened this issue Feb 13, 2022 · 0 comments
Open

remove indexed keyword from onlyOwner events #11

StErMi opened this issue Feb 13, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@StErMi
Copy link
Owner

StErMi commented Feb 13, 2022

It's true that those functions can be called only by the owner (that could still change) and having an indexed parameter will cost more gas (we are talking about really a little).

Removing that keyword makes the parameter not searchable. I would expect that monitoring tools would like to allow you to do that even if they are not indexed because they could index those events internally on their web2 DB.

@dannypostma do you think that it's a good tradeoff? I never used tools like Tenderly or OpenZeppelin Defender so the point before is only my assumptions on how I would do things on a web2 service.

Events where we could remove the indexed param:

  • StakingFeeUpdated
  • MaxSubscriptionsUpdated
  • SubscriptionMonthPriceUpdated
  • TreasuryWithdraw
  • TreasuryUpdated
  • StakingPayoutSent
  • RareBlocksStakingUpdated
@StErMi StErMi added the help wanted Extra attention is needed label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant