Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateAllowedSubscriptions should emit a AllowedSubscriptionsUpdate event and not for a single one #12

Open
StErMi opened this issue Feb 13, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@StErMi
Copy link
Owner

StErMi commented Feb 13, 2022

@dannypostma I would not bother to waste gas to recreate the array of subs that have changed, just emit the events passing the same params of the function.

While it's true that some subscriptions won't change value (because the value is the same) the end result would be that the contract will have the allow list equal to the one specified in the function param (if you didn't specify a 0x address to be allowed)

@StErMi StErMi added the help wanted Extra attention is needed label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant