Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT_ENOUGH_FUNDS error message on subscribe could be confusing #6

Open
StErMi opened this issue Feb 13, 2022 · 0 comments
Open

NOT_ENOUGH_FUNDS error message on subscribe could be confusing #6

StErMi opened this issue Feb 13, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@StErMi
Copy link
Owner

StErMi commented Feb 13, 2022

The problem here is that the tx will revert if the user has not specified the correct amount of eth required to rent a Pass for X months.

@dannypostma what could be a good message? INVALID_MSG_VALUE? It's still not helping much to understand what's wrong but I think that no one will interact with the contract directly so, in the end, it will always be up to the frontend to translate the revert message to a better UX message.
@StErMi StErMi added the help wanted Extra attention is needed label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StErMi