Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccov-clean not compatible on Windows #24

Closed
mscofield0 opened this issue Apr 28, 2021 · 4 comments
Closed

ccov-clean not compatible on Windows #24

mscofield0 opened this issue Apr 28, 2021 · 4 comments

Comments

@mscofield0
Copy link

Hi, right now the ccov-clean target uses rm to remove the binaries.list and profraw.list files.

It would be nice not to have to jump in WSL to generate code coverage reports.

@StableCoder
Copy link
Owner

Hi.

I've updated that to be platform agnostic as of 1d4bcb4. This should allow builds of individual ccov targets on Windows.

Unfortunately, the ccov-all* targets are still non-functional on Windows, and I'm still trying to figure out a solution.

@mscofield0
Copy link
Author

Thanks for the quick fix. Closing this now.

@mscofield0
Copy link
Author

mscofield0 commented Apr 29, 2021

Seems like the Linux version isn't working now:

$ cmake --build build/test --target ccov
[0/2] Re-checking globbed directories...
[1/13] cd .../build/test/ccov/profraw.list
FAILED: CMakeFiles/ccov-clean
cd .../build/test && /usr/bin/cmake -E rm -f .../build/test/ccov/binaries.list && /usr/bin/cmake -E rm -f .../build/test/ccov/profraw.list
CMake Error: cmake version 3.16.3
Usage: /usr/bin/cmake -E <command> [arguments...]

@mscofield0 mscofield0 reopened this Apr 29, 2021
@StableCoder
Copy link
Owner

Fixed via 2a6517a.

In this particular case, cmake -E rm was only added to CMake with v3.17.0. I've added a workaround for prior versions that uses the older cmake -E remove command instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants