Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access LookupDbType from other library #455

Closed
vdaron opened this issue Feb 9, 2016 · 2 comments
Closed

Access LookupDbType from other library #455

vdaron opened this issue Feb 9, 2016 · 2 comments

Comments

@vdaron
Copy link

vdaron commented Feb 9, 2016

Hi,

I would like to be able to access the LookupDbType method from SimpleStack.Orm and it seems that it's not possible anymore in the 1.50 pre-release.

internal static DbType LookupDbType(Type type, string name, bool demand, out ITypeHandler handler)

I used to call that method to retrieve dbType and ITypeHandler to generate my CREATE TABLE statements.

Thanks for feedback

@mgravell
Copy link
Member

mgravell commented Feb 9, 2016

I probably saw it and thought "there's no reason for that to be public, and
nobody should be using it". If I did remove it, it was probably a naughty
breaking change and I deserve a wrist slap. Probably the best option is if
I make it public, and add an [Obsolete("some message", false)] and you can
#pragma around it - that work?

On 9 February 2016 at 20:58, Vincent DARON notifications@github.com wrote:

Hi,

I would like to be able to access the LookupDbType method from
SimpleStack.Orm and it seems that it's not possible anymore in the 1.50
pre-release.

internal static DbType LookupDbType(Type type, string name, bool demand,
out ITypeHandler handler)

I used to call that method to retrieve dbType and ITypeHandler to generate
my CREATE TABLE statements.

Thanks for feedback


Reply to this email directly or view it on GitHub
#455.

Regards,

Marc

@vdaron
Copy link
Author

vdaron commented Feb 10, 2016

Would be perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants