Fixed #530 using technique that fixed #418 for async code. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While that solution works, wouldn't it be cleaner to have the ToList call already in the KeyPropertiesCache method? That way it wouldn't be possible to forget it in callers. Of course that solution would lead to more - maybe unnecessary - copies. But it seems like the various xyzPropertiesCache methods already return list copies when the requested type is already in the cache. Only if the cache is newly build the original list is returned (except for TypePropertiesCache that already returns a copy in both cases). |
|
It looks like this was solved and merged with #1048. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.