Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponseTimeout is unused #1029

Closed
hpk opened this issue Jan 3, 2019 · 2 comments
Closed

ResponseTimeout is unused #1029

hpk opened this issue Jan 3, 2019 · 2 comments

Comments

@hpk
Copy link
Contributor

hpk commented Jan 3, 2019

I've noticed this while trying to track down some flaky behavior with connections to ElastiCache. We'll periodically see total Redis connectivity failure on a single container for a number of minutes (manifested as every single operation timing out), followed by a connection reset message:

StackExchange.Redis.ConnectionFailureType - SocketFailure (ReadSocketError/ConnectionReset,
last-recv: 4777) on <host>/Interactive, Idle, last: GET, origin: ReadFromPipe, outstanding: 9161,
last-read: 1996s ago, last-write: 0s ago, unanswered-write: 1996s ago, keep-alive: 10s, state:
ConnectedEstablished, mgr: 9 of 10 available, in: 0, last-heartbeat: 0s ago, last-mbeat: 0s ago,
global: 0s ago, v: 2.0.513.63329 [StackExchange.Redis.RedisConnectionException]

In version 1.*, there was a ResponseTimeout configuration option that would reset the connection when no reply was received after a certain number of milliseconds. That config option is still present in version 2, but I don't see it being used anywhere.

Leaving aside the issue of what's causing these connection failures in the first place, how can we get SE.Redis to reset the connection in a reasonable time frame if it's throwing RedisTimeoutExceptions consistently?

@hpk
Copy link
Contributor Author

hpk commented Jan 15, 2019

Any update on this? Is the functionality previously provided by ResponseTimeout no longer supported? If so, it should be removed from the config options, or at least deprecated.

@NickCraver
Copy link
Collaborator

Removed by #1042, thanks for the cleanup! Closing this out to tidy up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants