Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why SE.Redis is no longer using RunContinuationsAsynchronously for asynchronous continuations #558

Closed
IlyaGrebnov opened this issue Jan 23, 2017 · 2 comments

Comments

@IlyaGrebnov
Copy link

Marc/Nick,

For personal education :) What is technical reason for SE.Redis to use ThreadPool.QueueUserWorkItem instead of RunContinuationsAsynchronously for asynchronous continuations?

@NickCraver
Copy link
Collaborator

I wish I could coherently answer this, unfortunately part of the answer is we don't know. Enabling them solved some edge cases, but also caused all sorts of totally inexplicable task behavior due to deep implementations in the runtime across various scenarios. It got to the point we rolled it back, basically doing more harm than good. Some deadlock situations were the most apparent. For example: #401 and #434.

@NickCraver
Copy link
Collaborator

Closing this out, since we don't actually have a better answer, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants