Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image-upload): allow for the option of showing a warning in upload display #251

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

yellis
Copy link
Contributor

@yellis yellis commented Jun 27, 2023

Describe your changes

  • Adds a warningMessage property to the image upload options
  • When this property is set, will display the text in a s-notice s-notice__warning with the same setup as is used for the old editor
  • Assumes that the text provided has been sanitized, per conventions used elsewhere

PR Checklist

  • All new/changed functionality includes unit and (optionally) e2e tests as appropriate
  • All new/changed functions have /** ... */ docs
  • I've added the bug/enhancement and other labels as appropriate

Additional context

Addresses:

It is setup for viewing in the Plugin Playground example page:

image

@yellis yellis added the enhancement New feature or request label Jun 27, 2023
@yellis yellis requested a review from b-kelly June 27, 2023 10:31
@yellis yellis self-assigned this Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 97d2a57
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/649d8a7379f41300086c3c5f
😎 Deploy Preview https://deploy-preview-251--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yellis yellis changed the title feat: allow for the option of showing a warning in the image upload plugin feat(image-upload): allow for the option of showing a warning in upload display Jun 27, 2023
Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yellis I made some minore changes to stay consistent with the image upload options we already provide.
The option name is now warningNoticeHtml.
I am going to merge this soon and cut a release asap.
Thanks for your contribution.

@giamir giamir merged commit 220f5e7 into main Jun 29, 2023
4 checks passed
@giamir giamir deleted the yellis/image-upload-warning branch June 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants