Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): make dropdown menuitems children of menu #255

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

dancormier
Copy link
Contributor

This is a minor accessibility tweak to improve the menu/menuitem relationship for controls

@dancormier dancormier requested a review from a team September 18, 2023 16:44
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 472822b
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/65087e5a7f588500081fcc59
😎 Deploy Preview https://deploy-preview-255--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit db4f033
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/65087e7b09457a0008a1e2b4
😎 Deploy Preview https://deploy-preview-255--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dancormier dancormier marked this pull request as ready for review September 18, 2023 16:56
@dancormier dancormier merged commit 2409a56 into main Sep 18, 2023
4 checks passed
@dancormier dancormier deleted the dcormier/a11y-fix-menu branch September 18, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant